Skip to content

[URP] Changing default CopyDepthMode to AfterTransparents #6058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 26, 2021
Merged

[URP] Changing default CopyDepthMode to AfterTransparents #6058

merged 8 commits into from
Oct 26, 2021

Conversation

manuele-bonanno
Copy link
Contributor

@manuele-bonanno manuele-bonanno commented Oct 19, 2021 •
edited
Loading

Purpose of this PR

This PR set Copy Depth Mode = AfterTransparents as new default for new projects. Old projects will still fall back to AfterOpaques for safety thanks to the versioning system.

To provide test coverage all the Yamato test renderers will now use AfterTransparents, except the MotionVectors renderer which required AfterOpaques to pass

Testing status

Ran all Yamato split tests

Comments to reviewers

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@manuele-bonanno manuele-bonanno marked this pull request as ready for review October 21, 2021 08:19
@manuele-bonanno manuele-bonanno requested review from a team as code owners October 21, 2021 08:19
@manuele-bonanno manuele-bonanno requested a review from a team October 21, 2021 11:12
@phi-lira phi-lira changed the base branch from master to universal/staging October 26, 2021 15:14
@phi-lira phi-lira merged commit 0e8988d into universal/staging Oct 26, 2021
@phi-lira phi-lira deleted the urp/new_copy_depth_default branch October 26, 2021 16:53
phi-lira pushed a commit that referenced this pull request Nov 9, 2021
@manuele-bonanno @phi-lira
[URP] Changing default CopyDepthMode to AfterTransparents (#6058)
09f9405 
* changed default CopyDepthMode to AfterTransparents

* Changed URP_Foundation tests renderers' copy depth mode to AfterTransparents

* changed the copy depth mode to AfterOpaques to fix the motion vectors test

* changed the Copy Depth Mode of all the renderers of the URP_Lighting test project to AfterTransparent

* changed the Copy Depth Mode of all the renderers of the URP_PostPro test project to AfterTransparent

* changed the Copy Depth Mode of all the renderers of the URP_Terrain test project to AfterTransparent

* updated the Linux player Vulkan reference image for test 206
@phi-lira phi-lira mentioned this pull request Nov 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ellioman ellioman ellioman approved these changes

@phi-lira phi-lira phi-lira approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

testing universal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@manuele-bonanno @ellioman @phi-lira