Reenable a test in the Lightmapping project since https://ono.unity3d… #6080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
urasmus
approved these changes
Oct 20, 2021
There was a problem hiding this comment.
The changes looks good.
However, https://ono.unity3d.com/unity/unity/pull-request/132498/_/lighting/bugfix/1352923-power-sampling-and-progressive-updates did not land until today so I think we need to wait until the next update of .yamato/_latest_editor_versions_trunk.metafile before we can merge this PR.
I approve on the condition that you postpone the merge until the next editor version update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reenable a test in the Lightmapping project since https://ono.unity3d com/unity/unity/pull-request/132498/_/lighting/bugfix/1352923-power-sampling-and-progressive-updates just landed