Skip to content

Conversation

manuele-bonanno
Copy link
Contributor

Purpose of this PR

Fix for https://fogbugz.unity3d.com/f/cases/1368853/

Currently URP resets GraphicsSettings.useScriptableRenderPipelineBatching every frame, overriding any changes done by user API calls

HDRP already only sets this value up only at pipeline creation:
https://sourcegraph.ds.unity3d.com/github.com/Unity-Technologies/Graphics/-/blob/com.unity[…]inition/Runtime/RenderPipeline/HDRenderPipeline.cs?L500


Testing status

tested the case repro project


Comments to reviewers

…at URP creation and not every frame (case 1368853 fix)
@manuele-bonanno manuele-bonanno requested review from a team as code owners October 21, 2021 11:12
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@phi-lira phi-lira changed the base branch from master to universal/staging October 26, 2021 15:16
@phi-lira phi-lira merged commit 4a2f7a6 into universal/staging Oct 26, 2021
@phi-lira phi-lira deleted the urp/cse_1368853_srp_batcher_toggle branch October 26, 2021 15:16
phi-lira pushed a commit that referenced this pull request Nov 9, 2021
…at URP creation and not every frame (case 1368853 fix) (#6094)
@phi-lira phi-lira mentioned this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants