Skip to content

Fix flood warning when combining XR with cinemachine brain #6158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix flood warning when combining XR with cinemachine brain #6158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion com.unity.render-pipelines.universal/Runtime/UniversalRenderPipeline.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,16 @@ internal void SetupXRStates()
throw new NotImplementedException("Only 1 XR display is supported.");

XRDisplaySubsystem display = xrDisplayList[0];
if(display.GetRenderPassCount() == 0)
// case 1074030 is having issues of flood wanrings complaining about cinemachine brain conflicting with xr camera.
// This is due to ShouldUseVRFieldOfView() returning true in Camera::SetVerticalFieldOfView because we have a vr device.
// URP 10.0.0 fixed this using https://github.com/Unity-Technologies/Graphics/pull/22 by setting disableLegacyRenderer to true
// to force a VRDeviceToXRDisplaySetup::TeardownShimFuncs(*this);. This is so there's no function override left in
// the shim table when calling UninstallVRDeviceShims from ProcessPendingTextureRequestsSynchronized which will finally
// call ShimTeardownIfActive(); to finally reset completely the legacy render device s_LegacyDevice = NULL;.which allows
// ShouldUseVRFieldOfView() to return false and therefore not throw a warning in Camera::SetVerticalFieldOfView.
display.disableLegacyRenderer = true;

if (display.GetRenderPassCount() == 0)
{
// Disable XR rendering if display contains 0 renderpass
if(!xrSkipRender)
Expand Down