-
Notifications
You must be signed in to change notification settings - Fork 855
Display diffusion profile overrides in volume debug menu #6182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP SRP Core Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
77faa29
to
3f44a9f
Compare
com.unity.render-pipelines.core/Editor/Debugging/DebugUIDrawer.Builtins.cs
Outdated
Show resolved
Hide resolved
3f44a9f
to
df050cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really minor things, I think you should also have @arttu-peltonen and @JulienIgnace-Unity on the review.
com.unity.render-pipelines.core/Editor/Debugging/DebugUIDrawer.Builtins.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.core/Editor/Debugging/DebugUIDrawer.Builtins.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.core/Editor/Debugging/DebugUIDrawer.Builtins.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.core/Editor/Debugging/DebugUIDrawer.Builtins.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.core/Editor/Debugging/DebugUIDrawer.Builtins.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.core/Editor/Debugging/DebugUIDrawer.Builtins.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Runtime/Debug/DebugDisplay.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great from my side. Only thing UI wise I noticed - the table view in the editor UI looks like it has darker font color now. Does this mean the UI is disabled, and you can't interact with it? It would be useful to be able to jump to the diffusion profile asset by clicking at it. If that's not easy to do, it's fine to leave as future improvement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick check with multiple cameras, multiple volumes affecting only certain cameras and it looks good.
Ran into a couple of Rendering Debugger bugs, but none are PR related:
https://fogbugz.unity3d.com/f/cases/1379200/
https://fogbugz.unity3d.com/f/cases/1379202/
Purpose of this PR
Added new debug widgets for the debug menu to show what diffusion profiles are currently in use by the volume system.
At the same time, i made a slight change to the volume debug table to improve readability, that you can see in the first screenshot below. I changed the column header name to be only the profile name, and added a row to link to the gameobjects contaning the profile. (that was an artist feedback from a long time ago)
This is how they show in the volume debug menu in the editor:

This is the same as above, but in play mode:

This is a test to show the look of the two new widgets, but outside of the volume debug menu table

Testing status
See the screenshots
Tested in a standalone build