Skip to content

Conversation

jonuuukas
Copy link
Contributor


Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?


This PR fixes https://fogbugz.unity3d.com/f/cases/1376820/

pretty simple PR if you check the code - render scale wasn't taken into the screen resolution when executing Lens Flare, so simply multiplying by it fixes the issue

Testing status

Describe what manual/automated tests were performed for this PR
Tested manually on Mac Editor - same behaviour is expected across all platforms, as nothing platform-specific is done here

Comments to reviewers

Notes for the reviewers you have assigned.

@jonuuukas jonuuukas requested review from a team as code owners November 3, 2021 14:08
@github-actions
Copy link

github-actions bot commented Nov 3, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

github-actions bot commented Nov 3, 2021

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@nigeljw-unity nigeljw-unity self-requested a review November 8, 2021 15:43
@phi-lira phi-lira changed the base branch from master to universal/staging November 10, 2021 09:57
@phi-lira phi-lira merged commit 8126066 into universal/staging Nov 10, 2021
@phi-lira phi-lira deleted the universal/lens-flare-scaling-fix branch November 10, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants