Skip to content

Conversation

eturquin
Copy link
Contributor

@eturquin eturquin commented Nov 4, 2021

Sensor SDK integration into HDRP. This PR introduces a few changes:

  • A couple new multicompile keywords in the path tracing pass of the Lit material
  • A corresponding support in the shader stripper, so that these keywords are only considered, and the corresponding variants compiled, when SensorSDK is present
  • An override system for the path tracing shaders, that allows the SensorSDK to shoot its own rays in the path tracing pass, and uses an alternate computation, different from regular path tracing integral computation

This has been tested with SensorSDK, and results are as expected.
This has also been tested without SensorSDK, where it shouldn't change anything at all in the path tracing behaviour, and this seems to be the case too.

Further tests can be made, to make sure that when SensorSDK is not present, nothing changes from before... :)

bayous and others added 30 commits October 18, 2021 16:34
…internal and only implemented in PathTracing.cs
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@sebastienlagarde sebastienlagarde marked this pull request as ready for review November 4, 2021 17:48
@sebastienlagarde sebastienlagarde merged commit d39aae9 into master Nov 4, 2021
@sebastienlagarde sebastienlagarde deleted the SensorSDK2022.1-GlobalVariable branch November 4, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants