Skip to content

Conversation

eh-unity
Copy link
Contributor

@eh-unity eh-unity commented Nov 5, 2021

Purpose of this PR

A simple and easily backportable fix for soft shadows on mobile (case 1374960).
Fixes soft shadows on mobile platforms (they were "hard" shadows by accident.)
Mobile soft shadow quality is still reduced compared to desktop for performance reasons (expected).

Previously:
image
After fix:
image


Testing status

Manually and visually tested on a sample scene.
Ran URP Foundation tests locally.


Comments to reviewers

Backported to 21.2

@github-actions
Copy link

github-actions bot commented Nov 5, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@phi-lira phi-lira changed the base branch from master to universal/staging November 10, 2021 09:59
@phi-lira phi-lira merged commit 032c36f into universal/staging Nov 10, 2021
@phi-lira phi-lira deleted the universal/fix-soft-shadow-mobile branch November 10, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants