Skip to content

Conversation

oleks-k
Copy link
Contributor

@oleks-k oleks-k commented Nov 8, 2021

Edited the Depth Priming MVP docs.

@oleks-k oleks-k requested a review from phi-lira November 8, 2021 01:01
@oleks-k oleks-k requested review from a team as code owners November 8, 2021 01:01
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

github-actions bot commented Nov 8, 2021

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

Copy link
Contributor

@GraphineNicolas GraphineNicolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The performance improvement depends on the amount of overlapping pixels" should mention that this only applies to the opaque pass. Something like this:
"The performance improvement depends on the amount of overlapping pixels in the opaque pass"

@phi-lira phi-lira requested review from manuele-bonanno and removed request for phi-lira November 18, 2021 14:28
@oleks-k
Copy link
Contributor Author

oleks-k commented Nov 25, 2021

"The performance improvement depends on the amount of overlapping pixels" should mention that this only applies to the opaque pass. Something like this: "The performance improvement depends on the amount of overlapping pixels in the opaque pass"

Thanks, I've added that phrase.

@oleks-k oleks-k merged commit e7aba06 into master Nov 25, 2021
@oleks-k oleks-k deleted the universal/2021.2/docs-depth-priming branch November 25, 2021 16:12
oleks-k added a commit that referenced this pull request Nov 29, 2021
* Backport of #6232: Edited the Depth Priming MVP docs.

* Implemented the comment from Manuele (opaque pass).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants