Skip to content

Conversation

hazelbit
Copy link
Contributor

Motivation

Small PR to copy the project using rsync to remote macOS devices to improve stability and reduce walltime.

The two main benefits are increased resilience (especially in regards to retries) and skipping . files/folders.

Quick note: rsync can compress files for transfer (-z, trading cpu utilization and network bandwidth) which led to a walltime penalty in our scenarios (see ticket for more details) so it is not part of the PR.

Draft PR with more pipelines to be scheduled, for success we should not see regressions in walltime and all further steps should find their required files in the same location (we should not see any pipeline failures related to this change). See ant-276.

@hazelbit hazelbit requested a review from a team November 15, 2021 15:05
@github-actions github-actions bot added the sdet label Nov 15, 2021
@theopnv
Copy link
Contributor

theopnv commented Nov 16, 2021

It's unclear whether the retry mechanism in case the connection was reset is built-in rsync or not. My understanding is that it's not, so if we want to have one maybe we'll have to have to call it inside some while loop? See this SO reply https://superuser.com/a/302843

@hazelbit
Copy link
Contributor Author

hazelbit commented Nov 16, 2021

That is right, I was relying on the retries: 2 mechanism (initial + up to two attempts). The -P implies --partial which is what we want for the retries (though arguably I should pass that explicitly, the second implied arg, --progress, is unused due to -q/--quiet, it's a leftover). Parts of the description were inaccurate as I've mentioned in the ticket which contains more background information ✔️

@hazelbit hazelbit closed this Nov 16, 2021
@hazelbit hazelbit deleted the ant-276 branch November 24, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants