-
Notifications
You must be signed in to change notification settings - Fork 855
[SRP] Add warning for users that want to use pixel perfect cam with other renderers #6294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. URP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
It appears that you made a non-draft PR! |
Fix verified on branch: 2022.1.0a16.2319
|
using System.Runtime.CompilerServices; | ||
|
||
[assembly: InternalsVisibleTo("PPv2URPConverters")] | ||
[assembly: InternalsVisibleTo("Unity.2D.PixelPerfect.Editor")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which internal API do you need access?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RenderPipelineConverter class. Made a new converter for 2D to URP Pixel Perfect Camera it so it will be a part of the Upgrade 2D (URP) Assets in the Render Pipeline Converter. See https://github.cds.internal.unity3d.com/unity/2d/pull/1514 (not sure if you have access)
Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
There are users that are using pixel perfect camera with 3d renderer and are unable to do so since we added a restriction with 2d renderer only. Added a warning for users to know that certain features will not be supported, and remove restriction from using in SRP.
Also expose RenderPipelineConverter to 2d pixel perfect package to create URP Pixel Perfect Converter in this changelist
https://github.cds.internal.unity3d.com/unity/2d/pull/1514
Testing status
Describe what manual/automated tests were performed for this PR
Tested on 2022.1.0a16
Open 3D URP Template scene.
Add a Pixel Perfect Camera component to the Main Camera.
Observe warning message.
Access to use Pixel Perfect Camera component is allowed.
Go to Project Settings -> Graphics -> Scriptable Render Pipeline Settings and remove Renderer Asset.
Observe error message on Pixel Perfect Camera component.
Create a 2D Renderer and 2D Renderer Asset
Go to Project Settings -> Graphics -> Scriptable Render Pipeline Settings and add the 2D Renderer Asset.
Observe no error or warning messages on component
Comments to reviewers
Notes for the reviewers you have assigned.