Skip to content

Conversation

jonuuukas
Copy link
Contributor

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?


As usual - need to make some calculations and Normals to use floats instead of halfs to avoid banding on Mobile devices. This was the bare minimum required to get the light rendering correctly.
Fix for (case 1375791)

Testing status

Describe what manual/automated tests were performed for this PR


Tested with repro project in the bug case with iPhone 12

Comments to reviewers

Notes for the reviewers you have assigned.

@jonuuukas jonuuukas requested review from a team as code owners November 22, 2021 11:58
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/jobDefinition/.yamato%252F_abv.yml%2523all_project_ci_trunk
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@phi-lira phi-lira changed the base branch from master to universal/staging December 7, 2021 08:23
@phi-lira phi-lira merged commit c133823 into universal/staging Dec 7, 2021
@phi-lira phi-lira deleted the universal/brdf-half-to-float-fix branch December 7, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants