Skip to content

Conversation

FrancescoC-unity
Copy link
Contributor

@tlaedre Need to momentarily revert this change as it creates problem on new projects trying to set up. We'll look into this, I suspect due to some other changes since yours.

Also another issue that spew errors when no probe volume is init, but is active.

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/jobDefinition/.yamato%252F_abv.yml%2523all_project_ci_trunk
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the SRP label Nov 25, 2021
@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@sebastienlagarde
Copy link
Contributor

Merging as it is a revert a previous issue

@sebastienlagarde sebastienlagarde merged commit eda1ca7 into master Nov 26, 2021
@sebastienlagarde sebastienlagarde deleted the HDRP/mixed-apv-fixes branch November 26, 2021 14:37
sebastienlagarde pushed a commit that referenced this pull request Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants