Skip to content

Conversation

EvgeniiG
Copy link
Contributor

Purpose of this PR

Add updated shader graph and material samples for hair and cloth authored by Yibing. These can be used by other artists as a starting point.

Testing status

Manual Tests

Character test in 2019.3.

@EvgeniiG EvgeniiG requested a review from a team as a code owner July 5, 2020 13:19
@sebastienlagarde sebastienlagarde changed the base branch from master to HDRP/staging July 5, 2020 13:20
@sebastienlagarde sebastienlagarde removed the request for review from a team July 5, 2020 13:22
@sebastienlagarde
Copy link
Contributor

sebastienlagarde commented Jul 5, 2020

@EvgeniiG @ Yibing. The subshader graph SGR_uvCombine within the hair shader graph don't work. It doesn't match the subgraph SGR_uvCombine. Please update

Note I have merge latest HDRP/staging and update cotton and silk. Also put the name in HDRP/Fabric instead of HDRP/character material.

Copy link
Contributor

@sebastienlagarde sebastienlagarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment, hair need to be updated

@EvgeniiG
Copy link
Contributor Author

Shader graphs and subgraphs have been updated.

@EvgeniiG EvgeniiG changed the title Add updated shader graph and material samples for hair and cloth [skip ci] Add updated shader graph and material samples for hair and cloth Jul 17, 2020
@sebastienlagarde
Copy link
Contributor

closing, replace by this PR: #2184

@sebastienlagarde sebastienlagarde deleted the HDRP/sg-samples-v2 branch November 12, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants