Skip to content

Conversation

kecho
Copy link
Contributor

@kecho kecho commented Dec 2, 2021

Purpose of this PR

Fixing issues with some sony shader compiler. This change removes a out uint into an out int.


Testing status

Internal yamato

@github-actions
Copy link

github-actions bot commented Dec 2, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the HDRP label Dec 2, 2021
@github-actions
Copy link

github-actions bot commented Dec 2, 2021

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@sebastienlagarde sebastienlagarde merged commit efeebfc into 2022.1/staging Dec 6, 2021
@sebastienlagarde sebastienlagarde deleted the HDRP/2022.1-fix-sony-compiler branch December 6, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants