Universal/fix shader paths #6476
Conversation
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. URP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
| // particleLit is the URP default material for new particle systems. | ||
| // ParticlesUnlit.mat is closest match to the built-in shader. | ||
| // This is correct (current 22.2) despite the Lit/Unlit naming conflict. | ||
| [Reload("Runtime/Materials/ParticlesUnlit.mat")] |
There was a problem hiding this comment.
What do you mean, the ParticlesUnlit.mat uses particles Lit shader?
There was a problem hiding this comment.
The resource code has everything named as ParticlesLit, and we return that as a default particle material.
However built-in default particle material is Unlit.
The Unlit material here uses the URP Unlit particle shader correctly.
The confusion here is that we have code named as "Lit" particle material, but it has always been Unlit.
Unlit appears to be correct from the perspective of matching the built-in renderer. There's never been ParticlesLit.mat
|
Formatting failure not caused by this PR. VFX failures also on master. |
2 participants
Purpose of this PR
Fix URP shader resource reload paths.
Testing status
Manually tested URP EditorResources "Reload All". No errors after this fix.