Skip to content

Conversation

anisunity
Copy link
Contributor

This PR fixes the water system on metal and re-enables the test for the device (even if the tests aren't passing, maybe we have a chance to update the screenshot?)

Testing status
Tested the fix on a Mac Mini M1 and seems to work just fine.

@anisunity anisunity added the HDRP label Dec 6, 2021
@anisunity anisunity requested review from a team and sebastienlagarde December 6, 2021 13:02
@anisunity anisunity self-assigned this Dec 6, 2021
@anisunity anisunity marked this pull request as ready for review December 6, 2021 13:02
@github-actions
Copy link

github-actions bot commented Dec 6, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

Copy link
Contributor

@JMargevics JMargevics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a good pass on metal. Things checked

  • All water body types
  • Forward and Deferred
  • All Anti-aliasing types
  • All DRS upscale filters
  • Built player

All seem good, no metal specific issues 👍🟢

@anisunity anisunity force-pushed the HDRP/fix-water-metal branch from 55f08d3 to 3347940 Compare December 10, 2021 08:43
@anisunity
Copy link
Contributor Author

Metal screenshot has been updated, relaunching the osx test

@sebastienlagarde sebastienlagarde merged commit 49bb4fd into master Dec 10, 2021
@sebastienlagarde sebastienlagarde deleted the HDRP/fix-water-metal branch December 10, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants