Skip to content

Conversation

bayous
Copy link
Contributor

@bayous bayous commented Dec 9, 2021

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • [x ] Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • [-] Have you updated the changelog? Each package has a CHANGELOG.md file.
  • [-] Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?

Fix a crash for project using SensorSDK on a standalone build. The crash was due to code stripped when shouldn't be.


Testing status

Describe what manual/automated tests were performed for this PR


Comments to reviewers

Notes for the reviewers you have assigned.

…ash was due to code stripped when shouldn't be.
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the HDRP label Dec 9, 2021
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@sebastienlagarde sebastienlagarde merged commit 62f8483 into master Dec 9, 2021
@sebastienlagarde sebastienlagarde deleted the FixSensorStandaloneBuildCrashDueToStrippedCode branch December 9, 2021 18:43
sebastienlagarde pushed a commit that referenced this pull request Dec 9, 2021
…ash was due to code stripped when shouldn't be. (#6555)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants