Enable DX12, Vulkan and Metal standalone tests [Skip CI] #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* OpenGLCore is currently not supported by HDRP so removed it. * DX12 was disabled, so enabled it.
* Revert the 2 previous commits as they were targetting the wrong folder/project (HDRP_Tests instead of HDRP_Runtime)
sebastienlagarde
approved these changes
Jun 8, 2020
sebastienlagarde
changed the title
sophiaaar
approved these changes
Jun 10, 2020
theopnv
pushed a commit
that referenced
this pull request
Jun 18, 2020
theopnv
pushed a commit
that referenced
this pull request
Jun 18, 2020
Removed opengl from player settings, in order for metal tests to work for the hdrp project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
Purpose of this PR
Until now, standalone tests for DX12 and Vulkan (Win) and Metal (OSX) were disabled for the all_hdrp_ci pipeline. This PR enables them.
Related Favro card: https://favro.com/organization/c564ede4ed3337f7b17986b6/058425719c1373dcb3bbe5a9?card=Uni-140566
Testing status
Manual Tests
Even if this shouldn't be necessary anymore thanks to the ruamel refactor, I checked the updated yaml file (
all-hdrp.yml) with the Yamato linter.Automated Tests
I've launched the ALL HDRP CI pipeline against fast-trunk: https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/HDRP%252Fenable-platforms-standalone-tests/.yamato%252Fall-hdrp.yml%2523All_HDRP_fast-trunk/2338393/job/pipeline
The standalone jobs now appear in that pipeline.
Links
Yamato: (Select your branch) https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics
Old PR Sebastien Lagarde originally started a PR here #394. It was closed so that the changes can be rewritten taking into account the new yamato files architecture.