Skip to content

Conversation

JulienIgnace-Unity
Copy link
Contributor

@JulienIgnace-Unity JulienIgnace-Unity commented Jan 24, 2022

Purpose of this PR

Fixed a null ref exception in Volume Explorer
https://fogbugz.unity3d.com/f/cases/1385391/


Testing status

Tested repro in the fogbugz case

@Unity-Technologies/gfx-qa-hdrp I'm actually not sure this fix will not break previous version. Could you test if the feature was broken as described in the case for version 22.1 21.2 and 10.x please? Otherwise backport may break silently the feature.

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@JulienIgnace-Unity JulienIgnace-Unity requested a review from a team January 25, 2022 09:18
Copy link
Contributor

@remi-chapelain remi-chapelain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trsuting the dev for the fix on trunk.

22.1 => repro, needs backport.
21.2 => repro, needs backport.
21.1 => does NOT repro, NO need for backport
20.3 => does NOT repro, NO need for backport

So need to remove the backport tag 10.x !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants