Skip to content

Conversation

anisunity
Copy link
Contributor

https://fogbugz.unity3d.com/f/cases/1399000/
There used to be two issues, one the current sun was ill defined when the shadow pass was culling. The second one was that the sunColor was potentially picked from the wrong directionalLightData (unlikely but possible). This PR fixes both issues

Testing status
Issue doesn't repro on the user dataset anymore.

@anisunity anisunity requested review from a team, kecho and sebastienlagarde February 1, 2022 10:03
@anisunity anisunity self-assigned this Feb 1, 2022
@anisunity anisunity marked this pull request as ready for review February 1, 2022 10:03
@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

Copy link
Contributor

@remi-chapelain remi-chapelain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with switching from three different sun casting shadows with color and intensity.

2229965bc28aeeb65fa781d6f2b4049f.mp4

@sebastienlagarde sebastienlagarde merged commit 7d7883b into master Feb 2, 2022
@sebastienlagarde sebastienlagarde deleted the HDRP/fix-clouds-no-shadow branch February 2, 2022 13:31
sebastienlagarde pushed a commit that referenced this pull request Feb 2, 2022
…ition of current Sun when the shadow pass is culled (case 1399000) #6925
sebastienlagarde added a commit that referenced this pull request Feb 2, 2022
* Changed the roughness value used for screen space reflections and ray traced reflections to match environment lighting (case 1390916). #680

* [HDRP] Improve custom pass name UI #6859

* Fixed using the wrong directional light data for clouds and the definition of current Sun when the shadow pass is culled (case 1399000) #6925

* [HDRP] Disable volumetric clouds in lens flare sample indoor scene #6953

* [Hdrp] Merge Hd/bugfix #6954

* Update HDAdditionalLightData.cs

Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: Rémi Chapelain <57442369+remi-chapelain@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants