Skip to content

Conversation

tomzig16
Copy link
Contributor

@tomzig16 tomzig16 commented Feb 1, 2022

Purpose of this PR

Backport for #5913

This PR fixes: https://fogbugz.unity3d.com/f/cases/1394156/
Previously there was an assert that was used as camera stack was not implemented, but now it works with it. When PR was made to change the if statement, assertion was forgotten hence it causes the regression. After removing it everything works correctly.


Testing status

Tested locally + automated ABV tests


Comments to reviewers

Although bug report tells that it is not a regression, we found that the issue appeared indirectly after the changes made in #4034

@tomzig16 tomzig16 requested review from a team as code owners February 1, 2022 14:12
@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%2Fall-urp.yml%23PR_URP_2021.2
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

github-actions bot commented Feb 1, 2022

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

Copy link
Contributor

@martint-unity martint-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@tomzig16 tomzig16 merged commit 60cf77a into 2021.2/staging Feb 10, 2022
@tomzig16 tomzig16 deleted the 2021.2/urp/editor/fix-gizmos-with-camera-stack branch February 10, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants