Skip to content

[HDRP 22.1] Backport various PRs #6946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 1, 2022
Merged

[HDRP 22.1] Backport various PRs #6946

merged 4 commits into from
Feb 1, 2022

Conversation

sebastienlagarde
Copy link
Contributor

@sebastienlagarde sebastienlagarde commented Feb 1, 2022 •
edited
Loading

Please read the Contributing guide before making a PR.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?

Testing status

Describe what manual/automated tests were performed for this PR

Comments to reviewers

Notes for the reviewers you have assigned.

sebastienlagarde and others added 4 commits February 1, 2022 23:49
@sebastienlagarde @emilybrown1
@FrancescoC-unity @anisunity @JulienIgnace-Unity @kecho @alelievr @alex-vazquez @eturquin @remi-chapelain
[HDRP 21.2] Backport various PRs (#6926)
e9dcd7a 
* fixed typo and made style guide fixes (#6749)

* style guide fixes (#6750)

* Added menu trail to change atlas resolution (#6755)

* Clarified how to find hdrp in package manager (#6756)

* made style guide fixes (#6762)

* added new instructions for photoshop colour channels (#6769)

* made naming of AO consistent (#6771)

* Removed reference to 3d with extras project (#6781)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Added default value (#6770)

* Added default value

* Fixed merge issue

* undo wrong fix

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Merge Hd/bugfix #6791

* Fix warning on baking set renaming #6808

* Renamed the Exposure field to Exposure Compensation in sky volume overrides (case 1392530). #6801

* Refresh baking set scene list when one baking set is removed. #6811

* clarified how to change mode (#6871)

* fixed screenshot annotation colour (#6872)

* fixed formatting (#6873)

* fixed name of Game view (#6874)

* fixed note formatting (#6875)

* new screenshot and fixed table formatting (#6889)

* minor style guide changes (#6904)

* remove italics, note formatting (#6906)

* fixed typo "on following GPUs" > on the following GPUs (#6909)

* Post Process can now be edited in the default frame settings. #6816

* Fixed errors spamming when in player mode due to ray tracing light cluster debug view (case 1390471). #6820

* Fixed missing unit in ray tracing related tooltips and docs (case 1397491). #6822

* [Fogbugz # 1386436] Fixing FPTL failing when near and far are very tight. #6826

* Fixed an issue where forced sky update would not update ambient probe. #6831

* Fixed a null ref exception in Volume Explorer #6834

* Cleaning up FPTL early out for ps4 and PC (#6882)

* Changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [HDRP] Fix static sky lighting update when render textures are updated #6863

* Quality update of custom post process (#6856)

* Disable the clouds in the indoor sample scenes (normal and DXR) #6908

* Fixed using the wrong coordinate to compute the sampling direction for the screen space global illumination. #6903

* Update VolumeParameter.cs

* Replaced view lighting tool with light anchor (#6829)

* Replaced view lighting tool with light anchor

* Update View-Lighting-Tool.md

* Apply formatting changes

* revert: Fix cached directional shadows disappearing when going out of shadow range to never reappear #6802

* [RPW][1386964]Fix undo for DebugUI.Enum fields on the rendering debugger. #6632

* More explicit error message when trying to use Shader Graph nodes HDSceneColor, NormalFromHeight, DDX, DDY or DDXY in ray tracing #6254

* [RPW]Fix recovering the correct index for DebugUI.Enum field that are not autoenum (#6901)

* Proper Indoors scene template volume

* Update 004-CloudsFlaresDecals.png

Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com>
Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
Co-authored-by: Rémi Chapelain <remi.chapelain@unity3d.com>
@emilybrown1 @sebastienlagarde
Fixed missing capital and UI bolding (#6876)
09a92af
@alex-vazquez @sebastienlagarde
[RPW]Fix Diffusion Profile Volume Component inspector when opened wit… …
f242529 
…#6799
@anisunity @sebastienlagarde
Disabled the "Reflect Sky" feature in the case of transparent screens…
18500ce 
…pace reflections for the water system. #6725
@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Shader Graph
/jobDefinition/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_trunk
Depending on your PR, you may also want
/jobDefinition/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_trunk
/jobDefinition/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_trunk

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/jobDefinition/.yamato%252F_abv.yml%2523all_project_ci_trunk
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@sebastienlagarde sebastienlagarde marked this pull request as ready for review February 1, 2022 23:07
@sebastienlagarde sebastienlagarde requested a review from a team as a code owner February 1, 2022 23:07
@sebastienlagarde sebastienlagarde merged commit 4356b6e into 2022.1/staging Feb 1, 2022
@sebastienlagarde sebastienlagarde deleted the HDRP/backport-misc-Pr branch February 1, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JulienIgnace-Unity JulienIgnace-Unity Awaiting requested review from JulienIgnace-Unity

Assignees

No one assigned

Labels

HDRP Shader Graph SRP testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sebastienlagarde @emilybrown1 @alex-vazquez @anisunity