Purge of unused resources in Render Graph #735
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a lot of gcalloc.
…nder graph is enabled.
… to Color Grading not being 100% neutral)
This reverts commit 505924b.
Reduced error message spam when encountering an execution error.
…Graphics into HDRP/rendergraph-graphicstests
Fixed a number of pass pruning issues.
This reverts commit 76a7c00.
This reverts commit 7b8acc0.
This reverts commit 84467f6.
This reverts commit 95952b0.
…Graphics into HDRP/rendergraph-enable-graphicstests # Conflicts: # TestProjects/HDRP_Tests/Assets/GraphicTests/Scenes/9x_Other/9401_MSAAForwardOnly.unity
Disabled test 9401 for render graph after merge conflict.
…b.com/Unity-Technologies/Graphics into HDRP/rendergraph-resource-puge # Conflicts: # com.unity.render-pipelines.core/Runtime/RenderGraph/RenderGraphResourceRegistry.cs # com.unity.render-pipelines.high-definition/Runtime/PostProcessing/PostProcessSystem.cs
…Graphics into HDRP/rendergraph-resource-puge # Conflicts: # .yamato/all-hdrp.yml # .yamato/hdrp-linux-vulkan.yml # TestProjects/HDRP_Tests/Assets/GraphicTests/Scenes/4x_PostProcessing/4060_CustomPostProcess.unity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR adds purging of unused resource in RenderGraph.
Any texture not used for a frame is being deallocated. This prevents inflation of GPU memory cost when using some feature only for a time.
The current scheme (next frame purge) is a bit drastic but in theory, used resources should not change too much from one frame to another and only during level change and things like that.
We can explore adding script control to this in the future.
This PR needs #728 to be merged before review.
Testing status
Manual Tests: What did you do?