Skip to content

Conversation

zwcmc
Copy link

@zwcmc zwcmc commented Sep 8, 2023


Purpose of this PR

Get the correct float4 result of 4 samples' comparison with coord.z.


Testing status

The SampleShadow_Gather_PCF function makes the shadow soft.

Fix the wrong components comparison in SampleShadow_Gather_PCF
@sebastienlagarde
Copy link
Contributor

Hi, thanks for the PR and notification. After investigation it is on purpose. The PR introducing this is here:

#2272

The code is only used for volumetric shadow:

"Cheaper PCF for directional light: Because the filtering we were using was already pretty low quality and because we operate in low res and very often we blur the result anyway, I changed it to still have PCF, but on the results of samples from a single gather. This saves quite a bit of ALU and bandwidth, while looking pretty much identical in all uses cases I found. I am sure we can find a case in which a slight difference is visible, but I couldn't :-)"

Are you saying any specific improvement? or Maybe you used this call in a different configuration than us? Thanks

@zwcmc
Copy link
Author

zwcmc commented Sep 9, 2023

Thanks; I got it.

@zwcmc zwcmc closed this Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants