Skip to content

Fix HD Template minor issue before publishing #8210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 3, 2025
Merged

Fix HD Template minor issue before publishing #8210

merged 3 commits into from
Oct 3, 2025
+343 −368

Conversation

remi-chapelain
Copy link
Contributor

Purpose of this PR

Upon review before publishing, I realized there were a few minor issues left.
This PR fixes :

  • Reflection probe fade distance increase to 100 (the pier made some start fading to early)
  • Lightmap encoding fix for all plateforms.
  • Added a proper sky in the prefab editing scene

Testing status

Opened the project and made sure the issue were fixed !

Comments to reviewers

N/A

@remi-chapelain remi-chapelain requested review from ValentinHume and removed request for ValentinHume October 3, 2025 08:57
JMargevics
JMargevics approved these changes Oct 3, 2025
View reviewed changes
Copy link
Contributor

@JMargevics JMargevics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🟢🚀

@claire-nicholson claire-nicholson merged commit 4f3d249 into master Oct 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JMargevics JMargevics JMargevics approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remi-chapelain @JMargevics @claire-nicholson