Skip to content

Conversation

FrancescoC-unity
Copy link
Contributor

First step to make the passes of post-processing render graph ready.

This is essentially changing the pattern of them so that they fit what rendergraph expects, some are changed more dramatically than others.

Skipped DoF for now since it is undergoing some changes.

I tested simple scenes with a bunch of the affected post processing passes in and ran the post processing visual tests.

Yamato: https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/HDRP%252Fpost-processing-render-graph/.yamato%252Fall-hdrp.yml%2523All_HDRP_fast-trunk/2571033/job

Copy link
Contributor

@JulienIgnace-Unity JulienIgnace-Unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Lots of unrelated whitespace changes though (parameter alignment mostly).

@FrancescoC-unity
Copy link
Contributor Author

FrancescoC-unity commented Jun 18, 2020

Looks good to me.
Lots of unrelated whitespace changes though (parameter alignment mostly).

Tried to realign now

…cessing-render-graph-step1

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/PostProcessing/PostProcessSystem.cs
@sebastienlagarde sebastienlagarde merged commit bfcda7b into HDRP/staging Jun 19, 2020
@sebastienlagarde sebastienlagarde deleted the HDRP/post-processing-render-graph branch June 19, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants