Skip to content

Finished management of Compute Buffers for render graph. #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 60 commits into from
Jun 19, 2020
Merged

Finished management of Compute Buffers for render graph. #966

merged 60 commits into from
Jun 19, 2020

Conversation

JulienIgnace-Unity
Copy link
Contributor

@JulienIgnace-Unity JulienIgnace-Unity commented Jun 18, 2020 •
edited
Loading

Purpose of this PR

The goal of this PR is to make Compute Buffers behave the same as texture in Render Graph.

  • Refactor of resource management to share all the code bewteen compute buffers and textures.
  • Used the new compute buffer APIs to port existing code (LightList build, Coarse stencil and Decal property mask)

There is no change in features, only implementation so current test suite should be enough.

Testing status

Manual Tests: What did you do?

  • Opened test project + Run graphic tests locally
  • Built a player
  • Checked new UI names with UX convention
  • Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
  • C# and shader warnings (supress shader cache to see them)
  • Checked new resources path for the reloader (in developer mode, you have a button at end of resources that check the paths)

@JulienIgnace-Unity
WIP for enabling valid graphics tests with Render Graph.
1df359c 
Fixed a lot of gcalloc.
@JulienIgnace-Unity
Fixed more GCAlloc and added an option for a test to not be run if re…
64ef0ca 
…nder graph is enabled.
@JulienIgnace-Unity
First batch of disabled tests.
505924b
@JulienIgnace-Unity
Fixed decal rendering
a6c1f8e
@JulienIgnace-Unity
Implemented ColorGrading and Uber Post (fixes a lot of small diff due…
04d0d20 
… to Color Grading not being 100% neutral)
@JulienIgnace-Unity
Revert "First batch of disabled tests."
4934ab9 
This reverts commit 505924b.
@JulienIgnace-Unity
Temp "texture not bound" error fix until bloom is implemented.
0dd42d8
@JulienIgnace-Unity
Fixed an error when using a stale invalid renderer list handle.
027a5c5 
Reduced error message spam when encountering an execution error.
@JulienIgnace-Unity
Add some debug info to compiled passes and removed wrong refCount++ o…
349a273 
…n passes.
@JulienIgnace-Unity
Merge branch 'HDRP/staging' of https://github.com/Unity-Technologies/…
a98f454 
…Graphics into HDRP/rendergraph-graphicstests
@JulienIgnace-Unity
Added possibility to disallow pass pruning
3eb0eb6 
Fixed a number of pass pruning issues.
@JulienIgnace-Unity
Small fixes
e1f9e08
@JulienIgnace-Unity
temporarily removed pruning of passes without product
1213511
@JulienIgnace-Unity
Fixed HDRP asset for test 5009
95952b0
@JulienIgnace-Unity
Implement alpha copy for post processes
1d97a44
@JulienIgnace-Unity
Small render graph error fix for motion vector pass.
0c62ef7
@JulienIgnace-Unity
Disabled for render graph tests that are currently broken.
84467f6
@JulienIgnace-Unity
Updated yamato with new render graph configurations
7b8acc0
@JulienIgnace-Unity
Fixed lens distortion
46a64a3
@JulienIgnace-Unity
Reenabled 4021
76a7c00
@JulienIgnace-Unity
Added an option to ignore tests when render graph is enabled.
9c4c38e
@JulienIgnace-Unity
Disabled for render graph tests that are currently broken.
e5d8dd0
@JulienIgnace-Unity
Reenabled 4021
ec2a4af
@JulienIgnace-Unity
Updated yamato script to add the RenderGraph pipeline.
399512c
@JulienIgnace-Unity
Revert "Reenabled 4021"
68fb303 
This reverts commit 76a7c00.
@JulienIgnace-Unity
Revert "Updated yamato with new render graph configurations"
fb085d0 
This reverts commit 7b8acc0.
@JulienIgnace-Unity
Revert "Disabled for render graph tests that are currently broken."
b3ac299 
This reverts commit 84467f6.
@JulienIgnace-Unity
Reverted HDRP test framework files (will go to another PR)
d0bb7fa
@JulienIgnace-Unity
Revert "Fixed HDRP asset for test 5009"
4ac6aa2 
This reverts commit 95952b0.
@JulienIgnace-Unity
Fixed HDRP asset for test 5009
0e1d250
@JulienIgnace-Unity
WIP Creation of compute buffers through render graph.
14a0cad
@JulienIgnace-Unity
Refactoring internal resource management to share more code (WIP)
4347974 
# Conflicts:
#	com.unity.render-pipelines.core/Runtime/RenderGraph/RenderGraphResourceRegistry.cs
@JulienIgnace-Unity
Share most of the code between compute buffers and textures.
d126be4
@JulienIgnace-Unity
Restored internal API for tests and fixed unit tests.
10acf55
@JulienIgnace-Unity
Merge branch 'HDRP/staging' of https://github.com/Unity-Technologies/…
a38c2a2 
…Graphics into HDRP/rg-create-computebuffer

# Conflicts:
#	.yamato/hdrp-linux-vulkan.yml
#	.yamato/hdrp-osx-metal.yml
#	.yamato/hdrp-win-dx11.yml
#	.yamato/hdrp-win-dx12.yml
#	.yamato/hdrp-win-vulkan.yml
#	com.unity.render-pipelines.core/Runtime/RenderGraph/RenderGraphResourceRegistry.cs
@JulienIgnace-Unity
Post merge fix
1f5e7e0
@JulienIgnace-Unity
Added APIs to create compute buffers through render graph.
489d2c9
@JulienIgnace-Unity
Refactor Light List build to use render graph created compute buffers.
e6931fc
@JulienIgnace-Unity
Small rewrite to facilitate implementing Probe Volume Light lists.
e4636d8
@JulienIgnace-Unity
Refactored handle to include an intermediate ResourceHandle struct (n…
064a640 
…ecessary to keep track of validity of the handles internally)
@JulienIgnace-Unity
Fixed light list binding for forward passes.
3b0cb24
@JulienIgnace-Unity
Removed usless SetGlobals
f8672b0
@JulienIgnace-Unity
Correctly bind cluster buffers for transparent forward passes.
0d75869
@JulienIgnace-Unity
Fixed light list build (wrong light count)
2edc865
@JulienIgnace-Unity
Fixed tile/cluster debug.
424855d
@JulienIgnace-Unity
Ported coarse stencil buffer to render graph.
b628507
@JulienIgnace-Unity
Moved decal property mask buffer to render graph created buffer.
7d1681f
@JulienIgnace-Unity
Fixed reset size of width/height
5a3d99f
@JulienIgnace-Unity
Fixed size of dbuffer property mask buffer.
49a908c
@JulienIgnace-Unity JulienIgnace-Unity marked this pull request as ready for review June 18, 2020 10:18
@JulienIgnace-Unity
Fixed unit tests
0fd07af
@JulienIgnace-Unity
Merge branch 'HDRP/staging' of https://github.com/Unity-Technologies/…
f732507 
…Graphics into HDRP/rg-create-computebuffer

# Conflicts:
#	com.unity.render-pipelines.core/Runtime/RenderGraph/RenderGraphResourceRegistry.cs
@sebastienlagarde sebastienlagarde merged commit cb8a7f3 into HDRP/staging Jun 19, 2020
@sebastienlagarde sebastienlagarde deleted the HDRP/rg-create-computebuffer branch June 19, 2020 10:09
@sebastienlagarde sebastienlagarde mentioned this pull request Jun 19, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

@FrancescoC-unity FrancescoC-unity FrancescoC-unity approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

HDRP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JulienIgnace-Unity @sebastienlagarde @FrancescoC-unity @theopnv