[Shader Graph] FlipBook fix #979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Jul 1, 2020
There was a problem hiding this comment.
Ran through all of the particle flipbooks in https://assetstore.unity.com/packages/essentials/tutorial-projects/unity-particle-pack-127325
Dimentions tested include 5x5, 6x6, 7x7, 8x8, 11x11, and 8x16.
marctem
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Manually Tested:
note: manual testing has been repeated for these cases on this branch
Working5x5Flipbook0
Various node set ups, including:
Technical Risk: 3/4 - Only affects this node, but in a big way
Halo Effect: 0/4 - Only affects this node
Automation
Added flipbook test scene to track regressions in indexing in the future
Notes to QA:
Landon: I also fixed the preview issue noted in previous iterations of this PR, please confirm.