Skip to content

Conversation

sebastienlagarde
Copy link
Contributor

Purpose of this PR

Upgrade guide documentation update + fix VFX asset and hdrp resource

Testing status

Manual Tests: What did you do?

  • Opened test project + Run graphic tests locally
  • Built a player
  • Checked new UI names with UX convention
  • Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
  • C# and shader warnings (supress shader cache to see them)
  • Checked new resources path for the reloader (in developer mode, you have a button at end of resources that check the paths)
  • Other:

Automated Tests: What did you setup? (Add a screenshot or the reference image of the test please)

Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics

Any test projects to go with this to help reviewers?


Comments to reviewers

Notes for the reviewers you have assigned.

@sebastienlagarde sebastienlagarde changed the base branch from master to HDRP/staging June 19, 2020 16:03
@github-actions github-actions bot added the HDRP label Jun 19, 2020
@sebastienlagarde sebastienlagarde changed the title Upgrade guide documentation update + fix VFX asset and hdrp resource Upgrade guide documentation update + hdrp resource Jun 19, 2020
@sebastienlagarde sebastienlagarde merged commit bd80b94 into HDRP/staging Jun 19, 2020
@sebastienlagarde sebastienlagarde deleted the HDRP/fix-documentaiton branch June 19, 2020 16:11
@sebastienlagarde
Copy link
Contributor Author

@JordanL8 added you for correction. Some sentence in the PR have already been corrected by you, come from a previous PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants