Skip to content

Conversation

sebastienlagarde
Copy link
Contributor

@sebastienlagarde sebastienlagarde commented Jun 21, 2020

Purpose of this PR


Testing status

Manual Tests: What did you do?

  • Opened test project + Run graphic tests locally
  • Built a player
  • Checked new UI names with UX convention
  • Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
  • C# and shader warnings (supress shader cache to see them)
  • Checked new resources path for the reloader (in developer mode, you have a button at end of resources that check the paths)
  • Other:

Automated Tests: What did you setup? (Add a screenshot or the reference image of the test please)

Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics

Any test projects to go with this to help reviewers?


Comments to reviewers

Notes for the reviewers you have assigned.

sebastienlagarde and others added 5 commits June 21, 2020 14:17
* Fixed 1253367 by rebaking probe with missing baked texture.

* Updated changelog

* Fix invalid memory copy and missing indice table replacement

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* - Making the planar probe atlas's format match the color buffer's format

* update changelog

* Fixing minor error

* Cleanup code

* Cleanup BC6H code for planar + don't use compute for copy

* Update documentation

* fix reference screenshots win vulkan

Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
@sebastienlagarde sebastienlagarde merged commit 63827f7 into master Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants