FIX: Hold interaction not staying performed (case 1195498). #1055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rene-Damm
commented
Feb 13, 2020
| Assert.That(performedControl, Is.SameAs(gamepad.buttonSouth)); | ||
| Assert.That(action.phase, Is.EqualTo(InputActionPhase.Waiting)); | ||
| Assert.That(trace, Canceled<HoldInteraction>(action, gamepad.buttonSouth, time: 11.5, duration: 1, value: 0.0)); | ||
| } |
There was a problem hiding this comment.
This one looks bad but basically I just rewrote the previous test with the now available InputActionTrace+ActionConstraint method which makes writing this kind of stuff just a ton easier. Also added a few extra checks.
jechter
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 1195498 (internal).