Fixed PrimitiveValue.FromString to handle NaN value #1140
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: https://issuetracker.unity3d.com/issues/inputsystem-error-when-vjoy-is-installed vJoy may produce NaN value that breaks the process of adding a device.
|
How can you edit the code in PrimitiveValues.cs without Unity somehow blocking the editing? When I edit the code and launch Unity, it seems to restore the code back to the way it was before editing. If I open PrimitiveValues.cs after launching Unity, the edit has been removed and the code restored. |
|
@onnimie yeah that sucks. I needed to just check if joystick is working so for me it was enough. |
|
Hi, I'm sorry for the delay, we had another look on the root cause of the issue with input system and vJoy, and fixed it in #1263, hence I'm closing this PR. Thanks for taking an effort and care to contribute and fix the issue! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issuetracker.unity3d.com/issues/inputsystem-error-when-vjoy-is-installed
vJoy may produce NaN value that breaks the process of adding a device.