Fixing deleting multiple bindings #1286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When deleting more than one binding,
BindingTreeItem.propertyof existing ones becomes invalid until the tree is recreated. But we made one time copy of them insideInputActionTreeView.DeleteDataOfSelectedItemswhich leads to copies going stale as soon as first item is deleted. When enough items is deleted in one go,property.GetParentProperty()starts pointing into completely wrong place, which leads to native errors inSerializedPropertycode.Changes made
When deleting, dynamically discover what action the current binding is bound to.