Skip to content

Conversation

jamesmcgill
Copy link
Collaborator

@jamesmcgill jamesmcgill commented Feb 17, 2023

Description

Refreshed the project and based now on last 2019 release (2019.4.40f1)

Changes made

  • Remove VSCode package as this now causes warning popup when opening in latest Unity trunk
  • Update copyright license year to 2023
  • Update project files to open cleanly in 2021.3.19f1 (current latest release of 2021)

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" with next release version correctly set.
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@jamesmcgill jamesmcgill requested a review from jimon February 17, 2023 11:47
@jimon
Copy link
Contributor

jimon commented Feb 17, 2023

Rebase on latest develop to fix CI issues

Btw maybe it makes sense to use 2021.3 as project version? 2020.3 goes EOL soon, and 2019.4 is EOL long time ago

@jamesmcgill jamesmcgill changed the title Refresh project to 2019.4.40f1 Refresh project to 2021.3.19f1 Feb 21, 2023
@jamesmcgill jamesmcgill force-pushed the update_min_project_2019.4.40f1 branch from d125fb5 to 686476f Compare February 22, 2023 14:54
@jamesmcgill
Copy link
Collaborator Author

Stayed with 2019.4 in the end.
Updating to 2021.3 caused manifest.json updates that break CI for lower versions.
Could have gone with 2020 as CI doesn't run 2019 but if we ever needed to check 2019 (still our min version) these changes might be confusing as upgrading is easy, but downgrading isn't at all.

@jamesmcgill jamesmcgill merged commit 45e5f86 into develop Feb 26, 2023
@jamesmcgill jamesmcgill deleted the update_min_project_2019.4.40f1 branch February 26, 2023 20:07
@jfreire-unity
Copy link
Collaborator

So 2019.4 is EOL but we still support it. What's the reason for that?
Also, Is there an alignment for the Unity packages to still support EOL Unity versions? Or is this something that some packages do and some don't?

@jimon
Copy link
Contributor

jimon commented Feb 27, 2023

@jfreire-unity package validator (upm-ci thingy) will require a build against 2019.4 otherwise it will fail the promotion, we need a new major package version release to change dependency on 2019.4. It's complicated ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants