Skip to content

Conversation

stefanunity
Copy link
Collaborator

@stefanunity stefanunity commented May 6, 2024

Description

We haven't run any of our automation on Linux but we probably should.

Changes made

Added Linux editor + standalone (mono + il2cpp) to the platforms to run our tests on.
None of them as currently added as required.

Notes

Disabled a few test which didn't work under Linux.
Followup for the disabled tests: ISX-1977

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" with next release version correctly set.
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@stefanunity stefanunity marked this pull request as ready for review May 7, 2024 10:05
@Pauliusd01 Pauliusd01 self-requested a review May 7, 2024 11:12
Copy link
Collaborator

@Pauliusd01 Pauliusd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The xinput part needing a separate commenting out seems weird but other than that LGTM

@stefanunity stefanunity merged commit d0e24f3 into develop May 7, 2024
@stefanunity stefanunity deleted the add-linux-ci branch May 7, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants