CHANGE: Make sure all callbacks are instrumented with ProfilerMarkers instead of Profiler.Begin/EndSample. #1992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surfnerd
force-pushed
the
input/convert-to-profiler-markers
branch
from
7e480ea to
f3dd7b1
Compare
|
Added @Pauliusd01 in case you want to QA before landing this. |
|
@ekcoh Is this for 1.11? We're 80% through release testing. If It's safe then I can pass it along, I'm not exactly an expert on profiling so all I did was profile a few scenes and checked if the same input calls show up as before |
Pauliusd01
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE: Make sure all callbacks are instrumented with ProfilerMarkers instead of Profiler.Begin/EndSample.
Description
Remove calls to Profiler.BeginSample/Profiler.EndSample so we can record profiler information in tests.
Changes made
Remove calls to Profiler.BeginSample/Profiler.EndSample so we can record profiler information in tests.
Testing
Tested to ensure the same profiler markers were showing up in the timeline.
Risk
low
Checklist
Before review:
Previous changelog entry is still valid.
- [ ] Changelog entry added.- Explains the change inChanged,Fixed,Addedsections.- For API change contains an example snippet and/or migration example.- JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.- Jira port for the next release set as "Resolved".- [ ] Tests added/changed, if applicable.- Functional tests~Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.- Performance tests.- Integration tests.- [ ] Docs for new/changed API's.- Xmldoc cross references are set correctly.- Added explanation how the API works.- Usage code examples added.- The manual is updated, if needed.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: