Skip to content

Conversation

AlexTyrer
Copy link
Contributor

@AlexTyrer AlexTyrer commented Oct 30, 2024

Description

A recent change was made to correct event processing when the Input System Update Mode was set to Fixed Update mode (#2026).

This has caused an issue when processing in Manual Mode resulting in "ISubmitHandler.OnSubmit is not being called when Update Mode is set to "Process Events Manually""

This change addresses that problem.

Testing status & QA

Local testing with user supplied project and scripts - tested all three modes (Fixed, Dynamic, Manual)
Automated testing.

Overall Product Risks

  • Complexity: Low
  • Halo Effect: Low

Comments to reviewers

None in particular.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@AlexTyrer AlexTyrer changed the title [Input System] Fix for event processing when operating in Manual Update mode (case ISXB-1141) FIX: Fix for event processing when operating in Manual Update mode (case ISXB-1141) Oct 30, 2024
@AlexTyrer AlexTyrer requested a review from ekcoh October 30, 2024 14:27
Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch. My biggest takeaway with all this is that polling APIs for events gets unnecessarily complex when multiple timelines are introduced. I have said it before, a reality for each timeline basically needs to exist.

@AlexTyrer AlexTyrer merged commit 747767f into develop Oct 30, 2024
80 checks passed
@AlexTyrer AlexTyrer deleted the isxb-1141/fix-manual-update-event-handling branch October 30, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants