Skip to content

FIX: The "Add Control Scheme..." popup now requires explicit Save/Close user action (case ISXB-1131) #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 6, 2024
Merged

FIX: The "Add Control Scheme..." popup now requires explicit Save/Close user action (case ISXB-1131) #2044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3971f67
[Input System] The "Add Control Scheme..." popup now requires explici…
AlexTyrer Nov 6, 2024
729a57b
[Input System] Added CHANGELOG entry for "Add Control Scheme..." popu…
AlexTyrer Nov 6, 2024
74b86e1
[Input System] Fix typo in CHANGELOG entry - removed extraneous final…
AlexTyrer Nov 6, 2024
82c40ad
[Input System] Licensing failure - try limiting to version 2021.3.45f
AlexTyrer Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .yamato/config.metadata
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
editors:
- version: 2021.3
- version: 2021.3.45f
- version: 2022.3
disable_tvos_run: true
- version: 6000.0
Expand Down
1 change: 1 addition & 0 deletions Packages/com.unity.inputsystem/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ however, it has to be formatted properly to pass verification tests.
- Fixed ISubmitHandler.OnSubmit event processing when operating in Manual Update mode (ISXB-1141)
- Fixed Rename mode is not entered and name is autocompleted to default when creating a new Action Map on 2022.3. [ISXB-1151](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1151)
- Fixed unexpected control scheme switch when using `OnScreenControl` and pointer based schemes which registed "Cancel" event on every frame.[ISXB-656](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-656)
- Fixed an issue with The "Add Control Scheme..." popup window so that it now persists until any changes are explicitly Saved or Cancelled [case ISXB-1131](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1131)

### Changed
- Added back the InputManager to InputSystem project-wide asset migration code with performance improvement (ISX-2086)
Expand Down
1 change: 0 additions & 1 deletion ...ages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/Views/ControlSchemesView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ public ControlSchemesView(VisualElement root, StateContainer stateContainer, boo
m_ModalWindow.Add(popupWindow);
root.Add(m_ModalWindow);
m_ModalWindow.StretchToParentSize();
m_ModalWindow.RegisterCallback<ClickEvent>(evt => CloseView());
popupWindow.RegisterCallback<ClickEvent>(evt => evt.StopPropagation());

m_ListView = controlSchemeVisualElement.Q<MultiColumnListView>(kControlSchemesListView);
Expand Down