FIX: Ensure callback delegates are created for ActionMaps added after an asset has already assigned to PlayerInput component (case ISXB-711) #2077
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PlayerInput component - ensure any added action map delegates are updated on ActivateInput() (case ISXB-711)
If action maps are added to an asset after the asset has been assigned to the PlayerInput component then the delegates need to be updated.
Before this change no OnXXX callbacks for the newly added ActionMaps were created leading to input loss.
Adding this sync in the ActivateInput() seems like the best compromise.
Testing status & QA
Local testing using supplied user project.
Automated tests
Overall Product Risks
Small change to update the action map callback delegates in ActivateInput.
Comments to reviewers
None in particular.
Checklist
Before review:
Changed
,Fixed
,Added
sections.Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.After merge: