Skip to content

Conversation

jfreire-unity
Copy link
Collaborator

Description

Change TouchSamples.asset from:
image

To this:
image

Currently, the latest versions of Cinemachine, 3.x, and Probuilder, 6.x have errors when using the Touch Sample assets.
Cinemachine 3.x has a breaking API change.
Probuilder 6.x has a mobile platform compilation error due to a ShaderGraph bug (see https://jira.unity3d.com/browse/UUM-94425)
This change avoids the problem when the Sample is imported through the Samples view of Input System Package Manager window since it shows the Samples dependency and downloads them accordingly.
image

Testing status & QA

Tested building for iOS when the Touch Samples uses the latest 5.2.3 version of Probuilder.

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity: Low
  • Halo Effect: Low

Comments to reviewers

If you import the .unitypackage to a U6 project, U6 will download both 3.x and 6.x versions of Cinemachine and Probuilder, respectively. Which means the problem will remain. Until the Probuilder version is fixed in U6, there's nothing we can easily do to avoid this.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this, arbitrary dependencies on related packages seems brittle

Currently using the latest versions of Cinemachine and Probuilder have errors when using this Samples assets.
The change minimizes them showing up when the Sample is imported through the Samples view of Input System Package Manager window.
Otherwise, the package installed status is on top of the package version which is undesirable.
@jfreire-unity jfreire-unity force-pushed the isxb-1245-pin-touchsamples-dependencies branch from 6536444 to 2e28965 Compare January 29, 2025 09:09
@jfreire-unity jfreire-unity requested review from stefanunity and removed request for stefanunity January 29, 2025 09:10
@jfreire-unity jfreire-unity self-assigned this Jan 29, 2025
@jfreire-unity jfreire-unity merged commit 4c3ce7e into develop Jan 29, 2025
94 checks passed
@jfreire-unity jfreire-unity deleted the isxb-1245-pin-touchsamples-dependencies branch January 29, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants