Skip to content

FIX: Attempt to fix UI test instabilities. [ISXB-1284] #2187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2025
Merged

FIX: Attempt to fix UI test instabilities. [ISXB-1284] #2187

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bc5d244
Attempt to fix test instabilities. Added a check dirty condition requ…
ekcoh May 23, 2025
f3ac45c
Merge branch 'develop' into isxb-1284-ui-test-instabilities
ekcoh May 30, 2025
bf9c6cd
Merge branch 'develop' into isxb-1284-ui-test-instabilities
ekcoh Jun 3, 2025
a9995c0
Merge branch 'develop' into isxb-1284-ui-test-instabilities
ekcoh Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions Assets/Tests/InputSystem.Editor/InputActionsEditorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ IEnumerator WaitForActionRename(int index, bool isActive, double timeoutSecs = 5
#endregion

[Test]
[Ignore("Instability, see ISXB-1284")]
public void CanListActionMaps()
{
var actionMapsContainer = m_Window.rootVisualElement.Q("action-maps-container");
Expand All @@ -88,7 +87,6 @@ public void CanListActionMaps()
}

[UnityTest]
[Ignore("Instability, see ISXB-1284")]
public IEnumerator CanCreateActionMap()
{
var button = m_Window.rootVisualElement.Q<Button>("add-new-action-map-button");
Expand Down Expand Up @@ -117,7 +115,6 @@ public IEnumerator CanCreateActionMap()
}

[UnityTest]
[Ignore("Instability, see ISXB-1284")]
public IEnumerator CanRenameActionMap()
{
var actionMapsContainer = m_Window.rootVisualElement.Q("action-maps-container");
Expand Down Expand Up @@ -166,7 +163,6 @@ public IEnumerator CanRenameActionMap()
}

[UnityTest]
[Ignore("Instability, see ISXB-1284")]
public IEnumerator CanDeleteActionMap()
{
var actionMapsContainer = m_Window.rootVisualElement.Q("action-maps-container");
Expand Down Expand Up @@ -195,7 +191,6 @@ public IEnumerator CanDeleteActionMap()
}

[UnityTest]
[Ignore("Instability, see ISXB-1284")]
public IEnumerator CanRenameAction()
{
var actionContainer = m_Window.rootVisualElement.Q("actions-container");
Expand All @@ -215,6 +210,8 @@ public IEnumerator CanRenameAction()

// Click twice to start the rename
SimulateClickOn(actionItem[1]);
yield return WaitForNotDirty();

// If the item is already focused, don't click again
if (!actionItem[1].IsFocused)
{
Expand Down