Skip to content

FIX: add com.unity.polyspatial.extensions to DependantsToIgnoreInPreviewApv #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 5, 2025

Conversation

stefanunity
Copy link
Collaborator

Description

A preview version of com.unity.polyspatial.extensions currently throws compile errors. Adding it to a list of package to ignore during our own APV as advised by RM.

Testing status & QA

  • green CI hopefully :)

Overall Product Risks

Low.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@jfreire-unity
Copy link
Collaborator

I don't understand the problem this fixes. Can you clarify?

A preview version of com.unity.polyspatial.extensions currently throws compile errors.

"Where" does it throw compile errors? Is it in our repo or somewhere else?

@codecov-github-com
Copy link

codecov-github-com bot commented Aug 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff             @@
##           develop    #2215      +/-   ##
===========================================
+ Coverage    68.10%   68.11%   +0.01%     
===========================================
  Files          367      367              
  Lines        53602    53602              
===========================================
+ Hits         36505    36511       +6     
+ Misses       17097    17091       -6     
Flag Coverage Δ
linux_2021.3_pkg 5.41% <ø> (ø)
linux_2021.3_project 70.35% <ø> (ø)
linux_2022.3_pkg 5.19% <ø> (ø)
linux_2022.3_project 65.20% <ø> (ø)
linux_6000.0_pkg 5.19% <ø> (ø)
linux_6000.0_project 68.01% <ø> (+<0.01%) ⬆️
linux_6000.1_pkg 5.19% <ø> (ø)
linux_6000.1_project 68.00% <ø> (ø)
linux_6000.2_pkg 5.19% <ø> (ø)
linux_6000.2_project 68.00% <ø> (-0.01%) ⬇️
linux_trunk_pkg 5.19% <ø> (ø)
linux_trunk_project 68.01% <ø> (+0.01%) ⬆️
mac_2021.3_pkg 5.40% <ø> (ø)
mac_2021.3_project 70.36% <ø> (ø)
mac_2022.3_pkg 5.18% <ø> (ø)
mac_2022.3_project 65.23% <ø> (ø)
mac_6000.0_pkg 5.19% <ø> (ø)
mac_6000.0_project 68.02% <ø> (ø)
mac_6000.1_pkg 5.19% <ø> (ø)
mac_6000.1_project 68.02% <ø> (ø)
mac_6000.2_pkg 5.19% <ø> (ø)
mac_6000.2_project 68.02% <ø> (ø)
mac_trunk_pkg 5.19% <ø> (ø)
mac_trunk_project 68.02% <ø> (ø)
win_2021.3_pkg 5.41% <ø> (ø)
win_2021.3_project 70.44% <ø> (ø)
win_2022.3_pkg 5.18% <ø> (ø)
win_2022.3_project 65.30% <ø> (-0.01%) ⬇️
win_6000.0_pkg 5.19% <ø> (ø)
win_6000.0_project 68.10% <ø> (ø)
win_6000.1_pkg 5.19% <ø> (ø)
win_6000.1_project 68.10% <ø> (ø)
win_6000.2_pkg 5.19% <ø> (ø)
win_6000.2_project 68.09% <ø> (+<0.01%) ⬆️
win_trunk_pkg 5.19% <ø> (ø)
win_trunk_project 68.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jfreire-unity jfreire-unity self-requested a review August 5, 2025 10:36
Copy link
Collaborator

@jfreire-unity jfreire-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on Slack convo, thanks!

@stefanunity stefanunity merged commit 4dde7be into develop Aug 5, 2025
150 of 154 checks passed
@stefanunity stefanunity deleted the ignore-polyspatial-in-apv branch August 5, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants