Skip to content

Conversation

unitALG
Copy link
Contributor

@unitALG unitALG commented Sep 16, 2025

Fixed missing images from workflow manual pages, including:

Description

The 3 subtopic Workflow pages are currently displaying broken images icons because those images were removed as part of work during an accessibility sprint (see PR#2185. I decided to restore the images because they are not screen shots, which was the original justification for removing them: they are images that demonstrate workflow.

These workflow images fit in nicely with the introductory images on the Concepts page and so they tie the workflows and concepts together effectively. So I also added the images back to the table on the Input System Workflows page, but made sure that the table is still accessibility compliant.

Testing status & QA

I generated the documentation locally.

Overall Product Risks

Very low risk, since these are fairly minor doc changes.

Comments to reviewers

In PR #2185, the images were removed because the writer was thinking that they were screen shots, which can easily drift out of date. However, these images were conceptual drawings that can make the concepts and workflows more accessible for many readers.

This should be straightforward to review but please reassign to another Input team member if you are unavailable.

Checklist

Before review:

  • No Changelog entry added because these were fairly trivial changes.
  • No Tests needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • FIX: Restored missing images

After merge:

  • No ports needed.

- Restored removed images (see #2185)
- Added the image references back to the table on the Workflows landing page
- Also replaced makeshift Notes and Tips with DocFx admonitions
@codecov-github-com
Copy link

codecov-github-com bot commented Sep 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff             @@
##           develop    #2236      +/-   ##
===========================================
- Coverage    68.14%   68.14%   -0.01%     
===========================================
  Files          367      367              
  Lines        53685    53685              
===========================================
- Hits         36585    36584       -1     
- Misses       17100    17101       +1     
Flag Coverage Δ
linux_2021.3_pkg 5.47% <ø> (ø)
linux_2021.3_project 70.40% <ø> (ø)
linux_2022.3_pkg 5.24% <ø> (ø)
linux_2022.3_project 65.25% <ø> (ø)
linux_6000.0_pkg 5.25% <ø> (ø)
linux_6000.0_project 68.05% <ø> (-0.02%) ⬇️
linux_6000.2_pkg 5.25% <ø> (ø)
linux_6000.2_project 68.06% <ø> (+<0.01%) ⬆️
linux_trunk_pkg 5.25% <ø> (ø)
linux_trunk_project 68.05% <ø> (ø)
mac_2021.3_pkg 5.46% <ø> (ø)
mac_2021.3_project 70.41% <ø> (ø)
mac_2022.3_pkg 5.24% <ø> (ø)
mac_2022.3_project 65.27% <ø> (ø)
mac_6000.0_pkg 5.24% <ø> (ø)
mac_6000.0_project 68.07% <ø> (ø)
mac_6000.2_pkg 5.24% <ø> (ø)
mac_6000.2_project 68.07% <ø> (ø)
mac_trunk_pkg 5.24% <ø> (ø)
mac_trunk_project 68.07% <ø> (ø)
win_2021.3_pkg 5.47% <ø> (ø)
win_2021.3_project 70.49% <ø> (ø)
win_2022.3_pkg 5.24% <ø> (ø)
win_2022.3_project 65.34% <ø> (-0.01%) ⬇️
win_6000.0_pkg 5.25% <ø> (ø)
win_6000.0_project 68.16% <ø> (+<0.01%) ⬆️
win_6000.2_pkg 5.25% <ø> (ø)
win_6000.2_project 68.15% <ø> (ø)
win_trunk_pkg 5.25% <ø> (ø)
win_trunk_project 68.15% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Pauliusd01 Pauliusd01 requested review from Pauliusd01 and removed request for PauliusUnity3d September 16, 2025 05:37
@Pauliusd01
Copy link
Collaborator

Pauliusd01 commented Sep 16, 2025

You need to run formatting (https://unity.slack.com/archives/C04RDRXRJ1L/p1756470893890159 ) And the title is not formatted correctly, it has to start with these categories (mentioned in the checklist):

"Commit message for squash-merge is prefixed with one of the list:
NEW: ___.
FIX: ___.
DOCS: ___.
CHANGE: ___."

Copy link
Collaborator

@Pauliusd01 Pauliusd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs the formatting fixed

@unitALG unitALG changed the title DOCATT-9570: Fixed missing images from workflow manual pages FIX: Fixed missing images from workflow manual pages (DOCATT-9570) Sep 16, 2025
@unitALG unitALG changed the title FIX: Fixed missing images from workflow manual pages (DOCATT-9570) FIX: Restored missing images from workflow manual pages (DOCATT-9570) Sep 16, 2025
@Pauliusd01 Pauliusd01 changed the title FIX: Restored missing images from workflow manual pages (DOCATT-9570) DOCS: Restored missing images from workflow manual pages (DOCATT-9570) Sep 17, 2025
@Pauliusd01 Pauliusd01 merged commit e4d1ee1 into develop Sep 17, 2025
112 of 115 checks passed
@Pauliusd01 Pauliusd01 deleted the docatt-qsprint-restore-imgs branch September 17, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants