This repository was archived by the owner on Nov 30, 2020. It is now read-only.
fix dx9 shader model 3 linear rendering DoF bug #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chman
reviewed
Jun 21, 2017
| @@ -105,7 +105,8 @@ public void Prepare(RenderTexture source, Material uberMaterial, bool antialiasC | |||
| material.SetFloat(Uniforms._RcpAspect, 1f / aspect); | |||
|
|
|||
| // CoC calculation pass | |||
| var rtCoC = context.renderTextureFactory.Get(context.width, context.height, 0, cocFormat); | |||
| // HACK by hdh, add RenderTextureReadWrite.Linear setting. in DX9 shader model 3 Linear rendering, without this will have bug | |||
There was a problem hiding this comment.
Can you remove this comment? Your name will still appear in the commit log, no need to put it in a comment :)
huangdonghai
force-pushed
the
v1
branch
2 times, most recently
from
d0d6146 to
402bd20
Compare
Chman
approved these changes
Jun 22, 2017
|
Waiting for QA to run a test pass before we merge. Thanks :) |
Kink3d
approved these changes
Jun 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under d3d9, shader model 3, linear rendering, DoF has a bug to read R8 coc render target, maybe write as linear, read as SRGB. this commit force RenderTextureReadWrite.Linear param when create R8 render target to solve this.