Addition of Color Ramp node #252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbbastian
suggested changes
Feb 21, 2018
| { | ||
| properties.Add(new PreviewProperty(PropertyType.Vector4) | ||
| { | ||
| name = name + "_c" + i, |
There was a problem hiding this comment.
This should be pre-generated to avoid allocation, as it is called every frame during preview rendering.
|
|
||
| properties.Add(new PreviewProperty(PropertyType.Vector2) | ||
| { | ||
| name = name + "_a" + i, |
|
I wouldnt bother amending this PR tbh. I have a gradient branch open already. I will likely merge the two approaches in some way. For example, my branch has a gradient type and slot that allows sampling the same gradient multiple times which I feel is very useful. |
|
Thanks for reviewing. Sure. I'd like to wait for @Kink3d's merge. I fixed the issues @pbbastian pointed out, just in case. |
Also added GradientControl that handles Gradient data in graph views.
|
Can we close this one in favor of #310? |
|
Sure. I close this as his PR is going to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to add the Color Ramp node that allows handling color/alpha gradient data in shader graphs.
It only allows handling static gradients -- these gradients are converted into inline constants and arithmetic operations in the shader, so that it can achieve nearly optimal performance (it's rather faster than using a look-up texture in most cases). On the other hand, it uses uniforms for previews in order to avoid recompilation on every modification, so it may be a bit less performant while edit time.
I chose the word "Ramp" because most node-based VFX systems (e.g. Houdini, Nuke, Blender, etc.) use this term, not "Gradient" nor "Gradation".