-
Notifications
You must be signed in to change notification settings - Fork 394
chore: add renderpipeline test for renderstreaming package #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
109042d
to
ef4452b
Compare
aac183f
to
de4bda7
Compare
de4bda7
to
1454f2c
Compare
059dc7c
to
ca493bf
Compare
kannan-xiao4
commented
Jan 26, 2021
kannan-xiao4
commented
Jan 26, 2021
kannan-xiao4
commented
Jan 26, 2021
karasusan
approved these changes
Jan 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me but the yaml file could be made simpler.
SampleScene.unity
in the test project is not needed. We should remove it.
a00cefe
to
ad400c8
Compare
This reverts commit ad400c8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trigger all RenderPipeline test {{ package.packagename }} {{ editor.version }}
ToDO:
Currently,
upm-ci project test
command is not working--extra-utr-arg
arguments. (This bug fixed by upm-ci-utilsdev
branch)We use this arguments for testfiltering. waiting for upm-ci latest relase.