Skip to content

Conversation

kannan-xiao4
Copy link
Contributor

  • Add renderpipeline test for renderstreaming package
  • These tests does not run automatically
  • If run tests, use trigger job Trigger all RenderPipeline test {{ package.packagename }} {{ editor.version }}

ToDO:
Currently,upm-ci project test command is not working --extra-utr-arg arguments. (This bug fixed by upm-ci-utils dev branch)
We use this arguments for testfiltering. waiting for upm-ci latest relase.

@kannan-xiao4 kannan-xiao4 force-pushed the chore/add-renderpipelinetest branch from 109042d to ef4452b Compare January 25, 2021 00:08
@kannan-xiao4 kannan-xiao4 force-pushed the chore/add-renderpipelinetest branch 2 times, most recently from aac183f to de4bda7 Compare January 26, 2021 07:40
@kannan-xiao4 kannan-xiao4 force-pushed the chore/add-renderpipelinetest branch from de4bda7 to 1454f2c Compare January 26, 2021 09:46
@kannan-xiao4 kannan-xiao4 force-pushed the chore/add-renderpipelinetest branch from 059dc7c to ca493bf Compare January 26, 2021 20:45
@kannan-xiao4 kannan-xiao4 changed the title [WIP] chore: add renderpipeline test for renderstreaming package chore: add renderpipeline test for renderstreaming package Jan 26, 2021
@kannan-xiao4 kannan-xiao4 marked this pull request as ready for review January 26, 2021 21:29
Copy link
Collaborator

@karasusan karasusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me but the yaml file could be made simpler.
SampleScene.unity in the test project is not needed. We should remove it.

@kannan-xiao4 kannan-xiao4 force-pushed the chore/add-renderpipelinetest branch from a00cefe to ad400c8 Compare January 27, 2021 03:08
@kannan-xiao4 kannan-xiao4 merged commit cf35e99 into develop Jan 27, 2021
@kannan-xiao4 kannan-xiao4 deleted the chore/add-renderpipelinetest branch January 27, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants