Skip to content

feat: Delegate SetDescription process to PeerConnection class #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 30, 2022
Merged

feat: Delegate SetDescription process to PeerConnection class #749

merged 7 commits into from
Aug 30, 2022

Conversation

kannan-xiao4
Copy link
Contributor

@kannan-xiao4 kannan-xiao4 commented Aug 30, 2022 •
edited
Loading

Delegate SetDescription process to Unity.RenderStreaming.PeerConnection class.
Changed to SetDescription processing is not executed in parallel.

Add test about Unity.RenderStreaming.PeerConnection class.

  • Confirm that the result is according to the current SignalingState.
  • Check the behavior when receiving description while processing other description.
PeerConnectionTest
- SendOfferTwiceImmediately
- SendAnswerTwiceImmediately
- OnGotOfferDescriptionAfterSendOfferImmediatelyInPolite
- OnGotOfferDescriptionAfterSendOfferImmediatelyInImPolite
- OnGotAnswerDescriptionAfterSendOfferImmediately(polite/impolite)
- OnGotOfferDescriptionAfterSendAnswerImmediately(polite/impolite)

@kannan-xiao4 kannan-xiao4 requested a review from karasusan August 30, 2022 07:52
@kannan-xiao4 kannan-xiao4 changed the title feat: Delegate Description process to PeerConnection class feat: Delegate SetDescription process to PeerConnection class Aug 30, 2022
@karasusan karasusan merged commit b3b8aff into develop Aug 30, 2022
@karasusan karasusan deleted the feat/urs-peerconnection branch August 30, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karasusan karasusan karasusan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kannan-xiao4 @karasusan