Skip to content

fix: refactor integration test infra, re-enable testproject-tools-integration, fix flaky tests on desktop & console platforms #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 117 commits into from
Feb 26, 2022
Merged

fix: refactor integration test infra, re-enable testproject-tools-integration, fix flaky tests on desktop & console platforms #1687

merged 117 commits into from
Feb 26, 2022

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Feb 12, 2022 •
edited
Loading

This PR migrates the runtime integration test helper classes into their own assembly in order to improve upon collaboration and standardization of writing Netcode for GameObject integration tests. This also includes additional modifications for some tests (to leverage from new features) in order to get them passing on all non-Desktop platforms.

This also includes an overhaul on the NetcodeIntegrationTest (formerly known as BaseMultiInstanceTest) that provides more functionality/flexibility depending upon your preferred style of writing integration tests.

MTT-2435

Testing and Documentation

Console Build:

This PR also has been consistently passing console builds.

@NoelStephensUnity
chore
53d63e5 
Create the new com.unity.netcode.testhelpers assembly.
Migrate SIPTransport into the new assembly.
@NoelStephensUnity
Merge branch 'develop' into fix/mtt-2435-and-integration-test-cleanup
c95a6c6
@NoelStephensUnity
chore
b6bcfe0 
Migrate MultiInstanceHelpers and BaseMultiInstanceTest into com.unity.netcode.testhelpers
@NoelStephensUnity
fix
6e52663 
Updating the NGO assembly.
@NoelStephensUnity
fix
390be29 
excluding unet if it is not present.
@NoelStephensUnity
update
7e7f211 
Migrated NetworkManagerHelper and NetworkVariableHelper into Unity.Netcode.TestHelpers.

Updated tests that used these classes to use the Unity.Netcode.TestHelpers namespace.
@NoelStephensUnity
chore
584d4cd 
Renaming MultiInstance to NetcodeIntegration.
So:
BaseMultiinstanceTest -> NetcodeIntegrationTest
MultiInstanceHelpers -> NetcodeIntegrationTestHelpers

This will probably change as I migrate some of NetcodeIntegrationTestHelpers into NetcodeIntegrationTest.
@NoelStephensUnity
update
8203daa 
Fixes for UNetTransport exclusion and added additional support for UTP in command line handler.
@NoelStephensUnity
Merge branch 'develop' into fix/mtt-2435-and-integration-test-cleanup
c9d447b
@NoelStephensUnity
update
fef818d 
Removed all references to NetcodeIntegrationTestHelpers.Run within tests.
Preparing NetcodeIntegrationTest.WaitForConditionOrTimeOut to be used in placed of the NetcodeIntegrationTestHelpers.WaitForCondition
@NoelStephensUnity
fix
950023e 
Missed a few references to NetcodeIntegrationTestHelpers.Run
@NoelStephensUnity
update
f28f462 
Testing only runtime references to this assembly and adding UnityEngine.TestRunner and NUnit library.
@NoelStephensUnity
chore
f6ec1d1 
renaming the assembly to better clarify that these test helpers are only for runtime integration tests.
@NoelStephensUnity
update
77fa3da 
This includes the core changes to NetworkSceneManager, integration test helper classes, and the scene handler integration test.
@NoelStephensUnity
test
a77e134 
Updated all of the rest of the tests that were modified in PR-1405
@NoelStephensUnity
update
809afc3 
Missed an update in NetworkScenemanagerTests
@NoelStephensUnity
Merge branch 'fix/networkscenemanager-interface-override-backport-dev…
92d486b 
…elop' into fix/mtt-2435-and-integration-test-cleanup
@NoelStephensUnity
update
546ea1c 
Merging #1691 into this branch ahead of it being merged to continue working on mtt-2435 while it waits to get approved.
@NoelStephensUnity
chore
5738dc9 
Migrate multiplayer tools helper classes out of Unity.Netcode.Runtime assembly and into the Unity.Netcode.TestHelpers.Runtime assembly.
@NoelStephensUnity NoelStephensUnity requested review from a team February 15, 2022 00:07
@NoelStephensUnity NoelStephensUnity mentioned this pull request Feb 15, 2022
Closed
NoelStephensUnity and others added 6 commits February 14, 2022 20:10
@NoelStephensUnity
Merge branch 'develop' into fix/mtt-2435-and-integration-test-cleanup
c201659
@NoelStephensUnity
Merge branch 'develop' into fix/mtt-2435-and-integration-test-cleanup
4881e1b
@NoelStephensUnity
update and fix
5dad53c 
Fixed the issue with two versions of IntegrationTestSceneHandler.
Updated the NetcodeIntegrationTest to be able to run all tests contained within a derived class using the same NetworkManager instances (i.e. doesn't spin up a NetworkManager per UnityTest)
@NoelStephensUnity
Update
dfd3c0d 
Added additional functionality to the setup and teardown process.
Minor addition to creating a player prefab that doesn't require passing an action to the StartSomeClientsAndServerWithPlayers method (which will be broken up into phases).
@NoelStephensUnity
test and update
e8139fd 
Migrating most of the editor serialization test methods into runtime tests.
@NoelStephensUnity
Update
c7eb9b0 
Added pre and post teardown virtual methods.
Fixed issues with the tools project SceneEventTests (still need to look through this more to make sure each scenario is being tested properly).
NoelStephensUnity and others added 5 commits February 24, 2022 18:54
@NoelStephensUnity @0xFA11
Update com.unity.netcode.gameobjects/Tests/Runtime/Metrics/NetworkObj…
90f9588 
…ectMetricsTests.cs

Co-authored-by: Fatih Mar <mfatihmar@gmail.com>
@NoelStephensUnity
update
aca170f 
using optionalUnityReferences.
@NoelStephensUnity
fix
451fe82 
Removed using system from the wrong file.
@NoelStephensUnity
fix-revert
d70d84c 
Reverting the suggested change.
@NoelStephensUnity
fix
a15a867 
disabling the Transform interpolation test as it is not stable and needs to be re-thought through.
@0xFA11 0xFA11 changed the title fix: mtt-2435 and integration test cleanup fix: integration test cleanup Feb 25, 2022
@0xFA11 0xFA11 changed the title fix: integration test cleanup fix: refactor integration test infra, re-enable testproject-tools-integration, fix flaky tests on desktop & console platforms Feb 25, 2022
@NoelStephensUnity
update
d66437b 
minimal conversion of TransformInterpolationTests to new NetcodeIntegrationTest.
@NoelStephensUnity
update
dbc3742 
Adding host or server selection capabilities to reduce code replication for this common task.
@NoelStephensUnity
Merge branch 'develop' into fix/mtt-2435-and-integration-test-cleanup
edf1e19
@NoelStephensUnity
update
96429b6 
Merge updates.
Refactored the RpcMessageHooks to be more generic and renamed it to MessageHooksConditional.  It allows for (n) number of message types to be assigned to (x) number of clients. Updated the tests that utilize the message hooks.
@NoelStephensUnity
Merge branch 'develop' into fix/mtt-2435-and-integration-test-cleanup
a89a6eb
@NoelStephensUnity
style
deec3d3 
renaming TimeOutHelper to TimeoutHelper.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review February 25, 2022 22:54
@NoelStephensUnity
style
880e5cc 
finishing the thought on the m_NetworkObject comment
@NoelStephensUnity
style
94dbecb 
white space fix
@NoelStephensUnity
style
9cd5cca 
removed system namespace.
@0xFA11 0xFA11 enabled auto-merge (squash) February 26, 2022 13:54
@0xFA11 0xFA11 merged commit dca06fd into develop Feb 26, 2022
@0xFA11 0xFA11 deleted the fix/mtt-2435-and-integration-test-cleanup branch February 26, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpmaurice lpmaurice Awaiting requested review from lpmaurice

@ashwinimurt ashwinimurt Awaiting requested review from ashwinimurt

2 more reviewers

@becksebenius-unity becksebenius-unity becksebenius-unity approved these changes

@0xFA11 0xFA11 0xFA11 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NoelStephensUnity @0xFA11 @becksebenius-unity