fix: ILPP filter out tests #2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he main runtime assembly
zain-mecklai
requested review from
NoelStephensUnity,
SamuelBellomo,
ShadauxCat and
ashwinimurt
… been populated at the time the test runs
NoelStephensUnity
approved these changes
Jul 18, 2022
…the messages more informative
…ies/com.unity.netcode.gameobjects into test/multiprocess_2022.2
…ure out how to block initial connection until init all steps is done
NoelStephensUnity
approved these changes
Jul 19, 2022
|
@ashwinimurt or @ThusWroteNomad can this be merged please? |
ashwinimurt
reviewed
Jul 20, 2022
| - unity-downloader-cli -u {{ editor }} -c editor -w --fast | ||
| - curl -s https://artifactory.prd.it.unity3d.com/artifactory/unity-tools-local/utr-standalone/utr{% if platform.name == "win" %}.bat --output utr.bat{% endif %}{% if platform.name != "win" %} --output utr && chmod +x ./utr{% endif %} | ||
| - {{ platform.editorpath }} -projectpath testproject -batchmode -nographics -quit -logfile BuildMultiprocessTestPlayer.log -executeMethod Unity.Netcode.MultiprocessRuntimeTests.BuildMultiprocessTestPlayer.BuildRelease | ||
| - {{ platform.editorpath }} -projectpath testproject -batchmode -quit -logfile BuildMultiprocessTestPlayer.log -executeMethod Unity.Netcode.MultiprocessRuntimeTests.BuildMultiprocessTestPlayer.BuildRelease |
There was a problem hiding this comment.
Is there a reason for removing -nographics? Do we need graphics for these tests?
There was a problem hiding this comment.
@ashwinimurt On linux, in 2022.2 the Editor was crashing with a high frequency with errors that looked like something was still trying to init the graphics stack. With this change, that problem was completely removed. I can try a different image and see if the problem is any better since I didn't see this problem when I was using a custom image and not one of the standard CI images for Ubuntu.
ashwinimurt
approved these changes
Jul 20, 2022
…ies/com.unity.netcode.gameobjects into test/multiprocess_2022.2
|
@ThusWroteNomad can you merge this please? |
…ies/com.unity.netcode.gameobjects into test/multiprocess_2022.2
…l failing so no point making this change, reverse it
|
@ashwinimurt or @ThusWroteNomad can this be merged please? |
ashwinimurt
approved these changes
Jul 26, 2022
|
@ashwinimurt or @ThusWroteNomad can this be merged please? |
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
* update timeout * remote UNET * fix: Stop populating ILPPMessageProvider with messages from outside the main runtime assembly * reset the changes to the scene * Initialiize the Rawgithash variable for the local execution case * Add a little more logging and see if we can find why allactons hasn't been populated at the time the test runs * Update the test to reduce the number of log messages as well as make the messages more informative * Lot when initlializatioon is complete * More logging clean up and adding information about registered test methods * Move init all steps to Awake instead of Start, eventually need to figure out how to block initial connection until init all steps is done * Move init to Awake * Fix missing log message in TestCoordinator Start method * Use GPU for Ubuntu image * Remove the nographics requirement and see if we can stabilize 2022.2 * Use -nographics and don't request a GPU for Linux * try to use ubuntu-20 and see if this is more stable * Use GPU for Linux and use Ubuntu 18 * Remove nographics again as it clearly makes an improvement * Adding a GPU and removing nographics just made things slower but still failing so no point making this change, reverse it Co-authored-by: Kitty Draper <kitty.draper@unity3d.com> Co-authored-by: ashwini <36935028+ashwinimurt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to scan fewer assemblies for ILPP. This helps to ensure that tests are getting the same data.
Changelog
Nothing for the changelog
Testing and Documentation
No API Deprecatiion